Inject defaultCatalog property to chaise-config and remove catalog alias creation step #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ias creation step while the alias method worked properly for one user, we found several issues when multiple people want to run the test cases: 1. when some one adds alias to a catalog, they will become the owner of that alias. so the next person won't be able to use the same alias on a different catalog. We might be able to solve this by passing the owner property and use the isrd-testers or isrd-gorups. but then we have to hardcode this in our chaise test step. 2. we are not able to run multiple instances of our test suite at the same time on the same server. so for example if user1 and user2 start running the test cases together, since we're using the same alias name in these two instances, the alias is going to be attached to only one of the catalogs which can cause issues.
jrchudy
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A while ago, I modified the catalog creation step of our test framework to add aliases to the created catalog. This allowed us to test the
defaultCatalogproperty since we could hardcode the alias inside thechaise-config.jsfiles.This worked properly while I was testing it on my own. However, since then, we have found that the alias creation has limitations when multiple users use the same alias or if multiple users want to run test cases simultaneously.
So this PR will remove the alias creation step and instead will inject a line into the
chaise-config.jslike the following:Since we don't need this for all the test cases, I added a new
addDefaultCatalogToChaiseConfigto our test options.Details
The following are the issues that we found with the alias method:
my-aliasto a catalog. At the same time, user2 runs the test case and assignsmy-aliasto their own newly created catalog. In this case, using themy-aliaswill refer to one of these catalogs, so one of the users is using the wrong catalog.ownerproperty while creating the alias, whoever creates it first will be its sole owner. So, if someone else attempts to use the same alias for a different catalog, they will get an error. To solve this, we would have to provide theisrd-testersas theownerof the alias. But that means that we have to hardcode this as part of chaise.